Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mime-type 2.0 support #641

Closed
auxbuss opened this issue Dec 2, 2013 · 20 comments
Closed

mime-type 2.0 support #641

auxbuss opened this issue Dec 2, 2013 · 20 comments

Comments

@auxbuss
Copy link

auxbuss commented Dec 2, 2013

I see that mail is tied to mime-types ~>1.16. I'm finding an increasing number of deps on mime-types 2.0.

Is there a roadmap for moving to mime-types 2.0?

@ConradIrwin
Copy link
Collaborator

It probably just needs to be tested and then committed. Pull requests
welcome :)

On Monday, December 2, 2013, Marc Cooper wrote:

I see that mail is tied to mime-types ~>1.16. I'm finding an increasing
number of deps on mime-types 2.0.

Is there a roadmap for moving to mime-types 2.0?


Reply to this email directly or view it on GitHubhttps://github.com//issues/641
.

@jeremy
Copy link
Collaborator

jeremy commented Dec 2, 2013

2.0 drops Ruby 1.8 support, so we can bump when mail drops support also.

On Mon, Dec 2, 2013 at 9:38 AM, Conrad Irwin notifications@github.comwrote:

It probably just needs to be tested and then committed. Pull requests
welcome :)

On Monday, December 2, 2013, Marc Cooper wrote:

I see that mail is tied to mime-types ~>1.16. I'm finding an increasing
number of deps on mime-types 2.0.

Is there a roadmap for moving to mime-types 2.0?


Reply to this email directly or view it on GitHub<
https://github.com/mikel/mail/issues/641>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/641#issuecomment-29633375
.

@auxbuss
Copy link
Author

auxbuss commented Dec 2, 2013

Ok. So, since having to use mime-types 2.0 forces mail 2.2.7 (2.5.4 is current), is the best option is to build the gem locally overriding the gemspec?

@jeremy
Copy link
Collaborator

jeremy commented Dec 2, 2013

That, or relax your other libs' dependency on mime-types 2.0.

On Mon, Dec 2, 2013 at 11:21 AM, Marc Cooper notifications@github.comwrote:

Ok. So, since having to use mime-types 2.0 forces mail 2.2.7 (2.5.4 is
current), is the best option is to build the gem locally overriding the
gemspec?


Reply to this email directly or view it on GitHubhttps://github.com//issues/641#issuecomment-29643181
.

@parndt
Copy link
Contributor

parndt commented Dec 9, 2013

Is there any strong opinion regarding when Mail will drop support for Ruby 1.8?
What I'm really asking is: would it be a worthwhile endeavour to investigate patching this?

@NielsKSchjoedt
Copy link

+1

xiaods pushed a commit to xiaods/refinerycms-news that referenced this issue Dec 12, 2013
 It's because the Mail gem depends on mime-types at ~> 1.16 and other gems have
 moved on to 2.0. Relates to mikel/mail#641
@pca2
Copy link

pca2 commented Jan 20, 2014

+1

1 similar comment
@oliver-k-yeh
Copy link

+1

@vdaubry
Copy link

vdaubry commented Feb 9, 2014

+1

@ameuret
Copy link

ameuret commented Feb 14, 2014

This is holding more and more people back every day (or forcing them to overrule other dependencies, with unknown risks). Why not freeze 1.8 support here ? Those people/projects mostly live in the past anyway.

@opensourceame
Copy link

+1 on this issue, it's becoming a common problem with projects I work with. Surely this can be fixed ?

@jtescher
Copy link

jtescher commented Mar 4, 2014

Any updates on this?

@NielsKSchjoedt
Copy link

This is such a pain...

@heidi
Copy link

heidi commented Mar 13, 2014

@ConradIrwin Tests pass locally after upgrading to the new version of mime-types. It looks like the ruby 1.8 builds are failing on your CI but the comments above lead me to believe that is expected/acceptable. Thoughts?

@maxrice
Copy link

maxrice commented Mar 14, 2014

+1

@arp
Copy link

arp commented Apr 25, 2014

Would be great to get that resolved eventually.

@ldiqual
Copy link

ldiqual commented May 21, 2014

+1

@opensourceame
Copy link

This has been open over six months now. What is holding it up? Surely it can't be support for Ruby 1.8 which lost official support a year ago!?

@carsonreinke
Copy link
Contributor

#695, looks like no release planned.

@bf4
Copy link
Collaborator

bf4 commented Jun 8, 2014

2.6.1 is released with mime-types support up to 3 and is merged into Rails 4 through edge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.