Allowed Mail::Address.new to accept non US ASCII strings #1034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ben5516. Downgrading i18n headers before parsing is a good approach, barring UTF8 parsing. Check out https://tools.ietf.org/html/rfc5504 for a full rundown—there's a good bit more to cover. |
|
@jeremy Hi! Could you please tell me what's up with this PR? Cant find it in 2.7.0 PR list. Waiting for such update |
|
@shved Note that this PR is open and hasn't been merged. There's a partial implementation that'll need more work to complete. |
|
Fixed by #1103 🖖 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if you instantiate an address list with a non US ASCII character you get a parse error. This PR fixes that problem by calling
Mail::Encodings.encode_non_usasciibefore Ragel tries to parse the address.