Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore MBCHARS env var to CI #1458

Closed
wants to merge 2 commits into from
Closed

Conversation

lewispb
Copy link
Contributor

@lewispb lewispb commented Oct 25, 2021

When we used Travis CI we had the MBCHARS environment variable as part of the matrix options.

This environment variable controls the Mail::Multibyte.proxy_class that mail uses.

https://github.com/mikel/mail/blob/6e5db59a349a2af9146d16d8f66cbd3b81cd905a/spec/environment.rb#L17-L24

This PR restores the ability to test on CI all Ruby versions against either Mail::Multibyte.proxy_class option.

@lewispb lewispb marked this pull request as ready for review October 25, 2021 08:03
Copy link
Collaborator

@jeremy jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, cool story… looks like we aren't using the Multibyte::Chars backend at all anymore. They stuck around for backward compatibility since they were publicly exposed, but usage was removed in #1094 and #1095.

@jeremy
Copy link
Collaborator

jeremy commented Oct 25, 2021

Closing this out since we aren't exercising the multibyte chars proxies within the lib anymore. We do have some specs that check that other APIs behave when passed Multibyte::Chars instances, but this is a niche scenario. Slating this subsystem for removal is sensible at this point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants