Fix RSpec deprecations and some spec improvements #976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updates syntax to resolve deprecations warnings.
alex-handley
force-pushed
the
improvement/deprecations_and_spec_improvements
branch
2 times, most recently
from
9ca638f
to
5a503a8
Compare
Very opinionated but I think it is clearer to assert using the expect syntax.
alex-handley
force-pushed
the
improvement/deprecations_and_spec_improvements
branch
from
5a503a8
to
bfc4768
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two RSpec deprecation warnings and I have also changed a few specs that were
=~rather then theexpectsyntax.