WIP: Supersedes #3 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 27, 2018 10:43
the environment variables in KUBECTL_PLUGINS_* basically aren't a thing anymore, need to go away as described in https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/#flags-and-argument-handling we need a different way to get $KUBECTL, $NAMESPACE, $TARGETUSER, and the container name. I've set some defaults that work for me, but with the possible exception of `which kubectl` they are probably no good for anyone else.
|
The plugin also can't be named exec-user anymore according to https://kubernetes.io/docs/tasks/extend-kubectl/kubectl-plugins/#name-conflicts-and-overshadowing |
since shadowing is a thing, I thought to call this plugin "userland"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know a better way to expect these command line options, I've just replaced them with optional defaults here that worked for my example use case. Supersedes PR #3 which fixed an earlier issue I had with this plugin.
This probably isn't getting merged anywhere as-is, but maybe having this PR open will help other people that find this issue against kubectl v1.13 and newer API clients that have breaking plugin API changes. This trick still works great against my reasonably current AKS cluster version!