This repository has been archived by the owner on Dec 22, 2023. It is now read-only.
Fix key warning #10
Merged
Fix key warning #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -47,6 +49,8 @@ var ProcessNodeDefinitions = function(React) { | |||
| }); | |||
| } | |||
|
|
|||
| elementProps.key = ++index; | |||
There was a problem hiding this comment.
Hey @lithin, since the key property is always set, do you mind moving this up to where elementProps is defined? So that it will look like this:
var elementProps = {
key: ++index
};
Thanks,
Mike
|
@mikenikles Thanks for the comment! Do you know why the tests are failing? |
|
@mikenikles Could you please merge this PR if you're happy with it? |
|
Sure thing, thanks a lot for your contribution @lithin! I will release it to npm tonight (in about 10 hours from now) |
|
@lithin version 0.1.2 is available in npm. Please let me know if you run into any problems. |
|
@mikenikles Thank you! |
|
Hi, |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing issue #7 - adds a unique key to every node that is parsed.