Skip to content
This repository has been archived by the owner on Dec 22, 2023. It is now read-only.

Create element keys per sequence #20

Merged
merged 1 commit into from
Apr 26, 2016
Merged

Conversation

aknuds1
Copy link
Collaborator

@aknuds1 aknuds1 commented Feb 3, 2016

Simplify code and make it more functional in style; generate element keys per sequence and not globally.

@aknuds1
Copy link
Collaborator Author

aknuds1 commented Apr 24, 2016

@mikenikles Could you please consider merging this?

@mikenikles
Copy link
Owner

Same as for #18, please update your branch and I'll include that PR in the next release.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling c2060d7 on aknuds1:child-keys into 273f4a4 on mikenikles:master.

@aknuds1
Copy link
Collaborator Author

aknuds1 commented Apr 25, 2016

@mikenikles Done.

@mikenikles
Copy link
Owner

@aknuds1 It looks like #18 causes merge conflicts with this PR. Do you mind updating this branch one more time?

@aknuds1
Copy link
Collaborator Author

aknuds1 commented Apr 25, 2016

Will do, once I have the time

On Mon, 25 Apr 2016, 16:20 Mike Nikles, notifications@github.com wrote:

@aknuds1 https://github.com/aknuds1 It looks like #18
#18 causes merge
conflicts with this PR. Do you mind updating this branch one more time?


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#20 (comment)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4f15f0c on aknuds1:child-keys into f1efdbb on mikenikles:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 639427d on aknuds1:child-keys into f1efdbb on mikenikles:master.

@aknuds1
Copy link
Collaborator Author

aknuds1 commented Apr 26, 2016

@mikenikles Should be ready now.

@mikenikles
Copy link
Owner

Awesome @aknuds1!

@mikenikles mikenikles merged commit 010e969 into mikenikles:master Apr 26, 2016
@aknuds1 aknuds1 deleted the child-keys branch April 27, 2016 14:01
@mikenikles mikenikles modified the milestone: v1.0.0 May 2, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants