Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate "AboutLibraries Library" listed #949

Closed
7 of 10 tasks
RyeGordo opened this issue Jan 25, 2024 · 5 comments · Fixed by #952
Closed
7 of 10 tasks

Duplicate "AboutLibraries Library" listed #949

RyeGordo opened this issue Jan 25, 2024 · 5 comments · Fixed by #952

Comments

@RyeGordo
Copy link

RyeGordo commented Jan 25, 2024

Duplicate "AboutLibraries Library"

The AboutLibraries lib is listed twice.

Implemented via Compose

LibrariesContainer(Modifier.fillMaxSize())

added com.mikepenz:aboutlibraries-compose-m3
added com.mikepenz.aboutlibraries.plugin

Details

  •  Used library version 10.10.0
  •  Used support library version
  •  Used gradle build tools version 34
  •  Used tooling / Android Studio version
  •  Other used libraries, potential conflicting libraries

Checklist

@mikepenz
Copy link
Owner

Thank you @RyeGordo that's because it lists every single module of your app.

there is the compose-m3 module and the core module, which both are listed.

Will look to adjust the title for the Material 3 lib variant.

You can also configure this behavior in the plugin settings: https://github.com/mikepenz/AboutLibraries?tab=readme-ov-file#gradle-plugin-configuration

By default it will keep duplicates:

var duplicationMode = DuplicateMode.KEEP

But you can change it to MERGE duplicates.

The default mode is SIMPLE (groupId and title to be equal)

var duplicationRule = DuplicateRule.SIMPLE

https://github.com/mikepenz/AboutLibraries/blob/develop/plugin-build/plugin/src/main/kotlin/com/mikepenz/aboutlibraries/plugin/AboutLibrariesExtension.kt

@mikepenz mikepenz reopened this Jan 25, 2024
@RyeGordo
Copy link
Author

RyeGordo commented Jan 25, 2024 via email

@mikepenz
Copy link
Owner

@RyeGordo
Copy link
Author

RyeGordo commented Jan 25, 2024 via email

@mikepenz
Copy link
Owner

Thank you very much!

The next release will now also have different names for the individual modules for more clarity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants