Failsafe on missing title for library
#880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Changes
- Created a new flag for the library builder.
- Created defaults when the flag is on:
- name - replaced by `"uniqueId"` which represents the package name.
- developers - replaced by an `emptyList()` if none exist.
5 tasks
mikepenz
requested changes
May 4, 2023
Comment on lines
10
to
12
| val firstItem: JSONObject = metaData.getJSONArray("libraries")[0] as JSONObject | ||
| firstItem.remove("name") | ||
| firstItem.remove("developers") |
There was a problem hiding this comment.
I believe this was accidentally left in for testing purposes, please remove
| @@ -4,9 +4,12 @@ import android.util.Log | |||
| import com.mikepenz.aboutlibraries.entity.* | |||
| import org.json.JSONObject | |||
|
|
|||
| actual fun parseData(json: String): Result { | |||
| actual fun parseData(json: String, recoverable: Boolean): Result { | |||
There was a problem hiding this comment.
Based on the adjustments, let's not have a recoverable flag for this behaviour, and let it happen automatically.
Especially as this is certainly an non-anticipated behaviour - and practically is not meant to happen (given the meta data is meant to contain that information)
This will also keep the API surface more simple, and does not require a new configuration for the exposed API.
Can you please adjust this
| * [Library.name] = use [Library.uniqueId] | ||
| * [Library.developers] = use [emptyList] | ||
| */ | ||
| fun recoverableMissingData(recoverable: Boolean): Builder { |
There was a problem hiding this comment.
Please drop this function, I don't think it's required to have this behaviour configured.
aboutlibraries-core/src/androidMain/kotlin/com/mikepenz/aboutlibraries/util/AndroidParser.kt
Show resolved
Hide resolved
- Added the recoverable functionality as the default behavior. - Removed accidentally added test code.
mikepenz
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
"uniqueId"which represents the package name.emptyList()if none exist.Update (07.05.2023)