Fix setting spanned text to IconicsTextView #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zTrap
approved these changes
Oct 10, 2021
mikepenz
approved these changes
Oct 11, 2021
|
Thanks for the merge. |
|
@kuba2k2 sorry it is not yet (forgot to press the button on maven) should be in the next 30 minutes |
|
Cool, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes setting spanned text to
IconicsTextView, which would just discard the span information before this change. It was caused by convertingCharSequencetoStringwhen building Iconics.A quick comparison is shown below, with a modified PlaygroundActivity (code attached in the commit). A bold span attached to the IconicsTextView is visible.
Note that even calling something like
iconicsTextView.text = iconicsTextView.textdiscarded the spans already - making the icons appear as crossed boxes.The problem probably does not affect normal TextViews, as they do not call the faulty builder method.