Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CommunityMaterial to 6.4.95 #613

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

leroyboerefijn
Copy link
Contributor

I followed the procedure in #606

All files were updated, but I cannot test if the project builds, since the gradle sync gives the following error: "This version of the Android Support plugin for IntelliJ IDEA (or Android Studio) cannot open this project, please retry with version 2021.1.1 or newer"

@mikepenz
Copy link
Owner

@leroyboerefijn the project currently uses the Chipmunk alpha of Android Studio: https://github.com/mikepenz/Android-Iconics/blob/develop/build.gradle#L64
It should be possible to lower that version though :).

Thank you very much for the PR. I'll have a look as soon as possible. Really appreciated!

cmd_eyedropper_plus('\uf4f1'),
cmd_eyedropper_remove('\uf4f2'),
cmd_eyedropper_variant('\uf4f3');
cmd_ab_testing:('\uF01C9'),
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@leroyboerefijn this will sadly not compile. could you please remove the : after the name.

Not sure if the css format changed, resulting in that one now being retained

@mikepenz
Copy link
Owner

Looks the mappings are in a range not allowed anymore. I'll probably need to do the setup manually again :/

@mikepenz mikepenz merged commit 2dcd26a into mikepenz:develop Nov 12, 2021
@mikepenz
Copy link
Owner

Thank you very much for the PR. I had to patch things and do it manually via icomoon (due to the codepoints not being in range otherwise)

@leroyboerefijn
Copy link
Contributor Author

Thanks a lot for finishing the PR! I didn't have time to look into it further

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants