Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FastAdapter.getPosition implementation question #988

Closed
DeweyReed opened this issue Apr 9, 2021 · 1 comment · Fixed by #989
Closed

FastAdapter.getPosition implementation question #988

DeweyReed opened this issue Apr 9, 2021 · 1 comment · Fixed by #989
Assignees
@mikepenz

Comments

@DeweyReed
Copy link
Contributor

About this issue

FastAdapter.getPosition loops through adapters and accumulates item count until the target is found. My question is, why to use position = adapter.adapterItemCount instead of +=? Using = remembers the last adapter item count rather than all item count before. Is this a bug, or is my understanding wrong?

Details

  • [5.3.5] Used library version
  • [4.1.3] Used tooling / Android Studio version

Checklist
@mikepenz mikepenz self-assigned this Apr 9, 2021
@mikepenz
Copy link
Owner

mikepenz commented Apr 9, 2021

This looks indeed like a bug. Thanks for pointing this out. Will have a look

mikepenz added a commit that referenced this issue Apr 9, 2021
@mikepenz
- ensure we compute the correct location in case of more than 2 child…
3a6324d 
… adapters

  - FIX #988
@mikepenz mikepenz mentioned this issue Apr 9, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikepenz mikepenz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix wrong position in case of more than 2 child adapters mikepenz/FastAdapter
2 participants
@mikepenz @DeweyReed