Feature request: Support strikethrough

[ZacSweers]

About this issue

Currently, strikethrough nodes are omitted from the rendered markdown.

~~This is strikethrough~~

Details

•  Used library version - 0.14.0
•  Used platform - Desktop
•  Used support library version
•  Used gradle build tools version - N/A
•  Used tooling / Android Studio version - N/A
•  Other used libraries, potential conflicting libraries - Jewel

Checklist

• Searched for similar issues
• Checked out the sample application
• Read the README
• Checked out the CHANGELOG
• Read the FAQ
• Checked out the MIGRATION GUIDE

[mikepenz]

I am afraid this is currently not exposed from the markdown library.

Example for italic text:

In comparison strikethrough text:

It only exposes EMPH or STRONG at this time:

• https://github.com/JetBrains/markdown/blob/76cec19922613609a5b2ab8110df830c708f7214/src/commonMain/kotlin/org/intellij/markdown/MarkdownElementTypes.kt#L26-L29

[ZacSweers]

Interesting, let me file something on their side for this!

[ZacSweers]

It looks like this is supported as a GFM-specific extension here: https://github.com/JetBrains/markdown/blob/76cec19922613609a5b2ab8110df830c708f7214/src/commonMain/kotlin/org/intellij/markdown/flavours/gfm/GFMElementTypes.kt#L29

Is that something we can configure in this library?

[mikepenz]

Thanks, had overlooked this one. Need to check why it is parsed differently than the emph and strong ones.

And yes, any type not handled can be handled via the custom component support: https://github.com/mikepenz/multiplatform-markdown-renderer/blob/develop/multiplatform-markdown-renderer/src/commonMain/kotlin/com/mikepenz/markdown/compose/Markdown.kt#L98

[mikepenz]

Good news. With the ~~text~~ it parses it properly. will include it.

Tested with ~text~ before, which I am usually used to.

[ZacSweers]

Nice!

[mikepenz]

Also a perhaps relevant note as I saw your code snippet for the custom component.

Strikethrough is part of the annotated string: https://github.com/mikepenz/multiplatform-markdown-renderer/blob/ef34d93c2bf8dbfb0488b0db65357c339d72b6b2/multiplatform-markdown-renderer/src/commonMain/kotlin/com/mikepenz/markdown/utils/AnnotatedStringKtx.kt
Which would require the Paragraph component to be overwritten and then it's internal parsing. I didn't consider this in the prior message. Given that, it would probably be quite more effort than a simple top level component.
Already exposed most classes to make that simpler, but it would still be quite a lift.

It might be a great addition to the library to also allow expanding the buildMarkdownAnnotatedString with custom conditions, so it is simpler to adjust this.