Store bound update method in constructor and use it as callback #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently each time update method is used as callback, it pass a new / different bound instance
The callback is not removed when
unobserve
is called and each time the same object is bound to a rivets view the callback count increases.Another side effect is the memory leak, independent of the object be rebound to a view, because observer instance cannot be collected so the binding and the HTMLElement.
The issue can be see in examples as simple as http://s.codepen.io/blikblum/debug/BjYPgo
Just break at
rivets.adapter['.'].unobserve
, click in bind / unbind and see 'person' callbacks increase