Prevent memory leaks in rivets adapters fix #10 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `.bind(this)` on `Observer#update()` create a new function instance each time: thereby, adapters can’t unobserve sightglass update callback. The solution is to keep an reference to the *binded* update method. A pull request (mikeric#11) has allready been proposed by @jccazeaux, but: - @jccazeaux ’s PR do not work at all: `var self` is unproperly initialised in the constructor, not in the methods that use it. And... anyway, even with `self` properly initialised, using `self.update` remains a mistake (self.update remain a function, not an instance method) - Maybe its ok to use `.bind()` instead of `var self`, because [browsers support](http://kangax.github.io/compat-table/es5/#Function.prototype.bind) is large enough (and polyfilling bind() is easy)
|
And here is two fiddle to illustrate the PR:
|
|
Oh my, you're right ! |
|
Hi @mikeric, is there anything that prevent you to merge this ? :) |
|
👍 |
|
This PR can be closed, #13 is the same and has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
.bind(this)onObserver#update()create a new function instance each time: thereby, adapters can’t unobserve sightglass update callback.The solution is to keep an reference to the binded update method.
A pull request (#11) has allready been proposed by @jccazeaux, but:
var selfis unproperly initialised in the constructor, not in the methods that use it. And... anyway, even withselfproperly initialised, usingself.updateremains a mistake (self.update remain a function, not an instance method).bind()instead ofvar self, because browsers support is large enough (and polyfilling bind() is easy)Fix #10 and mikeric/rivets#430