Fix/always evaluates callback on functions #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
April 26, 2015 13:37
…w function wich will result in memory leak in adapters.
…ime a new function wich will result in memory leak in adapters." This reverts commit 8eeffc7570064cf86075760f4b122d03cc181e7b.
…ck. This prevents bugs when function are in prototypes (function reference never changes, so callback is never called)
jccazeaux
pushed a commit
to jccazeaux/rivets
that referenced
this pull request
May 15, 2016
…eric/sightglass#16 is merged and installed on rivets. Will fix mikeric#572
jccazeaux
pushed a commit
to jccazeaux/rivets
that referenced
this pull request
May 15, 2016
…eric/sightglass#16 is merged and installed on rivets. Will fix mikeric#572
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Callback is now always called if observed value is a function. Fixes #15