Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/always evaluates callback on functions #16

Merged
merged 4 commits into from
Aug 8, 2016
Merged

Fix/always evaluates callback on functions #16

merged 4 commits into from
Aug 8, 2016

Commits on Apr 26, 2015

  1. Don't use .bind(this) on update callback. This creates each time a ne… 

    …w function wich will result in memory leak in adapters.
    Jean-Christophe Cazeaux committed Apr 26, 2015
    Configuration menu
    Copy the full SHA
    9eeffc7 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2015

  1. Revert "Don't use .bind(this) on update callback. This creates each t… 

    …ime a new function wich will result in memory leak in adapters."

This reverts commit 8eeffc7570064cf86075760f4b122d03cc181e7b.
    Jean-Christophe Cazeaux committed Oct 4, 2015
    Configuration menu
    Copy the full SHA
    9a2a354 View commit details
    Browse the repository at this point in the history

Commits on Feb 9, 2016

  1. Merge branch 'master' of https://github.com/mikeric/sightglass

    Jean-Christophe Cazeaux committed Feb 9, 2016
    Configuration menu
    Copy the full SHA
    2493f72 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2016

  1. If value is a function, sightglass should always evaluates the callba… 

    …ck. This prevents bugs when function are in prototypes (function reference never changes, so callback is never called)
    Jean-Christophe Cazeaux committed May 15, 2016
    Configuration menu
    Copy the full SHA
    7841b18 View commit details
    Browse the repository at this point in the history