EIP-1559 Support #10
Merged
EIP-1559 Support #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
antazoey
reviewed
Feb 28, 2022
Co-authored-by: Juliya Smith <yingthi@live.com>
|
@unparalleled-js @fubuloubu thanks for the thorough reviews. I'll be doing a release for this later tonight. lmk if you had any further feedback before I do. I added a couple GH issues for some things I want to get done that came out of our discussions (input validation and type 1 transactions). If either of you want to make a case about click, feel free to add one. I'm still unsure if the CLI commands should be a primary feature of this lib or if that should be left to the implementers of this lib. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds EIP-1559 support. Does not include EIP-2930 Type 1 transaction support (specifically access lists), but it lays the groundwork. Needs some more work on RLP encoding of access lists.
Closes #9