-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overzealous in its shell integration validation #66
Comments
This stopgap measure addresses mikesmithgh#66.
You cant detect shell integration is active from kitty settings if you are using manual integration. With manual integration everything happens in the shell, I suppose you could do something like run $SHELL -il -c "echo $PS1" | cat -v and check for the presence of the shell integration OSC codes in the output. Or look at the shell integration scripts in kitty and see what variables/functions they define for each shell and write your detection code as above but checking for those instead. Either way you'd need to special case fish. |
Hi @gregorias, thank you for the issue, could you provide the output of |
Hey @kovidgoyal! Thanks for the info. I am checking for the
But, I suppose this may not be reliable if the user is setting it up manually. Interesting idea about checking the OSC codes. I'm not sure if I need to be as strict on this check, maybe I can try and just warn if none of those OSC prompt markers are found. |
|
This stopgap measure addresses mikesmithgh#66.
🎉 This issue has been resolved in version 2.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Hey @gregorias, thanks for reporting I went ahead and removed the validation. It is too complicated to worry about trying to check for all conditions and since it is documented as a requirement, I think this is safe 👍 |
is_valid_extent_keyword
incorrectly marks a manual shell integration setup as invalid.I configured my setup as instructed in the README, and when I tried to get a scrollback of the last commandm, I got
'ERROR: Kitty shell integration is disabled and/or no-prompt-mark is set',
fromvalidate_extent
. I suspected that the validation check was a false positive and it only checked for the automated shell integration, so I disabled the check and everything worked fine. I was able to get a scrollback of the last command.I suspect that
is_valid_extent_keyword
should also check for signs of manual shell integration although I don't yet how to do this.KITTY_SHELL_INTEGRATION
environment variable gets cleared, for instance.Thank you for this plugin. It's an amazing achievement to integrate the scrollback with Neovim so well. I'm looking forward to continued development of this plugin to make it even more seemless and flexible.
The text was updated successfully, but these errors were encountered: