UART support and higher level API #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em in a SPI derived class.
…ers bitfields and definitions.
… in a multi-slave system.
…MC5130 quick config guide.
…initialization. References have been changed to pointers to allow copy assignment and avoid dynamic memory management.
… helper function to set all of the acceleration parameters at once.
…ending on the motor speed
…ad was successful and add an extra check when reading a register
…tecture int is 16 bits long on this architecture !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Mike,
Here are some additions to your TMC5130 code which helped me a lot to get started with this chip !
The library now comes with :
The API had to change a little to accomodate for these changes but existing code should still work with minor modifications.
Planned additions:
setPositionResolution()could be added for applications needing microstep positioning.Also, what do you think about renaming the classes to TMC5130, TMC5130_SPI, etc. ? The class names are becoming rather verbose...
Let me know if you think that these changes should not be merged because of the API break or if you prefer to merge them later.
Thanks again for sharing the initial code :)
Cheers,
Tom