@pytest.mark.enable_socket doesn't work

[wimglenn]

The mark to enable_socket doesn't seem to work. The fixture socket_enabled still works.

pytest-socket==0.3.1
pytest==3.10.0

Tried also on pytest==3.6.3 (earliest version supported according to pytest-socket metadata), same result.

MCVE test_something.py:

import socket
import pytest

def f():
    socket.socket()

@pytest.mark.enable_socket
def test_1():
    f()

def test_2(socket_enabled):
    f()

Demo:

$ pytest --disable-socket -v
======================================= test session starts =======================================
platform linux -- Python 3.7.0, pytest-3.10.0, py-1.7.0, pluggy-0.8.0 -- /tmp/example/.venv/bin/python3
cachedir: .pytest_cache
rootdir: /tmp/example, inifile:
plugins: socket-0.3.1
collected 2 items                                                                                 

test_something.py::test_1 FAILED                                                            [ 50%]
test_something.py::test_2 PASSED                                                            [100%]

============================================ FAILURES =============================================
_____________________________________________ test_1 ______________________________________________

    @pytest.mark.enable_socket
    def test_1():
>       f()

test_something.py:9: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
test_something.py:5: in f
    socket.socket()
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

args = (), kwargs = {}

    def guarded(*args, **kwargs):
>       raise SocketBlockedError()
E       pytest_socket.SocketBlockedError: A test tried to use socket.socket.

.venv/lib/python3.7/site-packages/pytest_socket.py:72: SocketBlockedError
=============================== 1 failed, 1 passed in 0.04 seconds ================================```

[wimglenn]

There seems to be a test for this:

https://github.com/miketheman/pytest-socket/blob/0.3.1/tests/test_socket.py#L104-L115

But it looks like it's asserting on the exact opposite of what it should be asserting..

[mcallaghan-bsm]

@miketheman - any update on #28 ? :) would be nice to fix, we just ran into this

Adding latest information, still an issue with these versions:

pytest                 5.2.2
pytest-socket          0.3.3
Python 3.7.3

[miketheman]

I'll try to get to evaluating these scenarios and fix this weekend.

[Alexander3]

Workaround:

@pytest.mark.enable_socket
@pytest.mark.vcr()
def test_fetch_weather():

gives E pytest_socket.SocketBlockedError: A test tried to use socket.socket.
but

@pytest.mark.vcr()
def test_fetch_weather(socket_enabled):

works