fixes parsing of flf files when last line is empty #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The code change looks good and makes sense; I'll have to check it out when I'm off work. Thanks for submitting the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i believe this fixes #5. it should now be possible to bring back fuzzy and wavy! (some other live fonts were also broken--like maxfour.)
load_extended_characters iterates over the last lines of the file, and tries to parse it as long as the line is not blank.
however,
if i && i.empty?will not provide the expected result if the line is""(in the file) akanil(in ruby). rails has #blank, which would be perfect. but!i || i.empty?should work.http://apidock.com/rails/Object/blank%3F
in short--it was the flf files with totally blank lines at the end that were breaking.