Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes parsing of flf files when last line is empty #10

Merged
merged 1 commit into from Oct 19, 2016

Conversation

@common-nighthawk
Copy link
Contributor

common-nighthawk commented Oct 17, 2016

i believe this fixes #5. it should now be possible to bring back fuzzy and wavy! (some other live fonts were also broken--like maxfour.)

load_extended_characters iterates over the last lines of the file, and tries to parse it as long as the line is not blank.

however, if i && i.empty? will not provide the expected result if the line is "" (in the file) aka nil (in ruby). rails has #blank, which would be perfect. but !i || i.empty? should work.
http://apidock.com/rails/Object/blank%3F

in short--it was the flf files with totally blank lines at the end that were breaking.

@miketierney
Copy link
Owner

miketierney commented Oct 17, 2016

The code change looks good and makes sense; I'll have to check it out when I'm off work. Thanks for submitting the PR!

@miketierney miketierney merged commit bf15977 into miketierney:master Oct 19, 2016
1 check failed
1 check failed
semaphoreci The build failed on Semaphore.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.