Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for PHP7 and PHPUnit 5.0? #120

Closed
kdambekalns opened this issue Dec 2, 2015 · 8 comments
Closed

Support for PHP7 and PHPUnit 5.0? #120

kdambekalns opened this issue Dec 2, 2015 · 8 comments
Labels
task

Comments

@kdambekalns
Copy link

Now that PHP7 has been tagged and PHPUnit 5.0 is stable, are there any plans to make vfsStream compatible to those?
@mikey179
Copy link
Member

mikey179 commented Dec 2, 2015

PHP7 compatibility should come in December, even though I don't think the current version is not compatible, at least the tests didn't show a significant problem except for the output of a warning which is raised when simulating insufficient disk space, but that shouldn't effect most users.

Regarding PHPUnit 5.0 I don't see that there needs to be done anything about this. vfsStream has no runtime dependency to PHPUnit, and the dev dependency doesn't matter to users. If I'm not missing something here that shouldn't be a problem.

@kdambekalns
Copy link
Author

Well, didn't dig into it yet, but at least those "uninitialized strong offset" notices in https://travis-ci.org/kdambekalns/flow-development-collection/jobs/94757895 seem to be related to PHP7. Probably the "uniform variable access" changes, as far as we guess.

kdambekalns added a commit to kdambekalns/vfsStream that referenced this issue Dec 4, 2015
@kdambekalns
Fix uninitialized string offset in newDirectory()
6fb0e95 
When running on PHP 7 this caused test failures (possibly only with
high error reporting).

Fixes bovigo#120
@kdambekalns kdambekalns mentioned this issue Dec 4, 2015
Closed
@mikey179
Copy link
Member

mikey179 commented Dec 4, 2015

After digging into it I think it is not related to PHP 7, I was able to reproduce this with PHP 5.6.4. The problem is that the call to vfsStream::setup() passes a directory name with trailing slash, causing the vfsStream::newDirectory() method to create a directory instance with an empty name. I fixed this with 0ea19cb, a trailing slash will no longer cause the creation of such a directory instance.

@kdambekalns
Copy link
Author

I assumed it was related to PHP 7, since it didn't cause problems so far, but the code looks "broken" regardless of the PHP version. :-)

Anyway, thanks! Any chance to get a 1.6.1 tagged today?

@mikey179
Copy link
Member

mikey179 commented Dec 4, 2015

Done, just released 1.6.1. I'll leave this issue open until PHP 7 compatibility is fully verified.

@kdambekalns
Copy link
Author

Thanks! For us it works so far…

@mikey179
Copy link
Member

mikey179 commented Jan 5, 2016

There is still a problem with a bug in PHP 7 itself: https://bugs.php.net/bug.php?id=71287

mikey179 pushed a commit that referenced this issue Jan 5, 2016
add test which reproduces PHP 7 test failure in smallest possible way
732c6cb 
The bug highlighted by this test is the one that prevents removing
the allowed failure on the Travis build for PHP 7. When this is fixed
the PHP 7 support tracked with #120 will finally be possible.

See PHP bug https://bugs.php.net/bug.php?id=71287 for further reference.
@mikey179
Copy link
Member

The bug is fixed in PHP 7.0.3.

@mikey179 mikey179 added the task label Jan 11, 2016
@photodude photodude mentioned this issue Feb 4, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kdambekalns @mikey179