[pixiv] rankings: add support for the new daily AI and daily AI R18 lists #3214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thatfuckingbird
changed the title
mikf
added a commit
that referenced
this pull request
Nov 15, 2022
(#3214, #3221) In remembrance of @thatfuckingbird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
title says it all.
btw, i think it might be better to error out if the mode is not found in mode_map instead of falling back to daily as default. caught me offguard for a moment when i thought this new ranking mode just works when it was just downloading the daily ranking (yea, should have checked the logs and noticed the warning though...)