Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigpy.mri.poisson hangs when seed & calib arguments are passed #102

Open
ad12 opened this issue Dec 6, 2021 · 9 comments
Open

sigpy.mri.poisson hangs when seed & calib arguments are passed #102

ad12 opened this issue Dec 6, 2021 · 9 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ad12
Copy link
Contributor

ad12 commented Dec 6, 2021

Describe the bug
sigpy.mri.poisson hangs when both the seed and calib arguments are passed in.

To Reproduce
See this colab below
https://colab.research.google.com/drive/1k0w6KjkPHx8U8K8dXmaFVi9hO1Cg1Z1e?usp=sharing

Expected behavior
Passing both these arguments together should not cause the program to hang

@ad12 ad12 added the bug Something isn't working label Dec 6, 2021
@sidward
Copy link
Collaborator

sidward commented Dec 7, 2021

Thanks for the report. This is really strange -- I am not sure why modifying the seed would cause anything to hang, but I see it on my side as well.

@sidward
Copy link
Collaborator

sidward commented Dec 8, 2021

@ad12 I just pushed a commit (815e17d) that hopefully fixes the problem for you -- It does on my end. Please re-open if this is not the case.

@sidward sidward closed this as completed Dec 8, 2021
@sidward
Copy link
Collaborator

sidward commented Dec 8, 2021

@ad12 If you are able, can you submit a PR with your reproducing code as a test? I would like to add it in-case numba/jit has an issue with the current fix later on.

@sidward
Copy link
Collaborator

sidward commented Dec 8, 2021

Reopening -- This is not fixed for all cases. We think this is an issue with Numba.

@lukasfolle
Copy link

I encountered this problem too. For a quick fix was changing https://github.com/mikgroup/sigpy/blob/master/sigpy/mri/samp.py#L157 to just @jit.

@sidward
Copy link
Collaborator

sidward commented Dec 20, 2021

Do you have an estimate of the performance penalty, if any?

@lukasfolle
Copy link

I havent benchmarked it. Probably depends also on the input size.

@sidward
Copy link
Collaborator

sidward commented Feb 16, 2022

Hi, sorry for the delay in getting to this -- would you be able to benchmark it at all? No worries if not.

@lukasfolle
Copy link

lukasfolle commented Feb 17, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants