Update tracy integration, allow parent projects to include RmlUi profiling markers #518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've not looked over the code yet, but with those changes I was able to super easily just enabled it after switching 2 options
I will take a look at the code tomorrow :) |
|
@p2004a Does it work when you compile RmlUi as a static library? |
p2004a
reviewed
Oct 9, 2023
I've actually tried only as static library, not shared. If RmlUi is shared, also tracy would need to be linked as shared, their cmake has config for it, but it's using static as default, whereas with RmlUi is using shared as default so AFAIU it can cause issue if the project using both libraries is not explicitly itself setting the |
…iling markers, solves #516 Tracy client can now be included in one of three ways, in prioritized order: 1. Using target Tracy::TracyClient from parent project. 2. As a config package. 3. With Tracy source files located in 'Dependencies/Tracy'. Adds three new CMake options: - `RMLUI_TRACY_PROFILING`: Enable profiling, replaces the old option `ENABLE_TRACY_PROFILING`. - `RMLUI_TRACY_MEMORY_PROFILING`: Overloads global operator new/delete for memory inspection. - `RMLUI_TRACY_CONFIGURATION`: Only relevant for multi-config generators. If enabled, adds Tracy as a separate configuration, otherwise adds Tracy to all configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracy client can now be included in one of three ways, in prioritized order:
Adds three new CMake options:
RMLUI_TRACY_PROFILING: Enable profiling, replaces the old optionENABLE_TRACY_PROFILING.RMLUI_TRACY_MEMORY_PROFILING: Overloads global operator new/delete for memory inspection.RMLUI_TRACY_CONFIGURATION: Only relevant for multi-config generators. If enabled, adds Tracy as a separate configuration, otherwise adds Tracy to all configurations.Solves #516.