Resolve Errors Around Failed PDB Updates Against Deleted PDBs #57
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the following error we were seeing in production logs which is related to #54.
The issue is occurs because the
reconcilePDBs
loop deletes the PDB then attempts to update it after it is deleted.This is resolved by ending the loop early if we delete the PDB.
I've also added a
RetryOnConflict
wrapper around theupdate
andcreate
methods since they're easy to add from theclient-go
library and prevent possible issues in the future around updating existing PDBs.