Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve Errors Around Failed PDB Updates Against Deleted PDBs #57

Merged
merged 1 commit into from
Aug 15, 2024
Merged

Resolve Errors Around Failed PDB Updates Against Deleted PDBs #57

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,10 @@ func (n *PDBController) reconcilePDBs(ctx context.Context, desiredPDBs, managedP
"namespace": managedPDB.Namespace,
"selector": managedPDB.Spec.Selector.String(),
}).Info("")

// If we delete a PDB then we don't want to attempt to update it later since this will
// result in a `StorageError` since we can't find the PDB to make an update to it.
continue
}

// check if PDBs are equal an only update if not
Expand Down