feat(mysql): support order by nulls first/last
#5021
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5021 +/- ##
=======================================
Coverage 99.66% 99.66%
=======================================
Files 221 221
Lines 16212 16252 +40
Branches 3894 3907 +13
=======================================
+ Hits 16158 16198 +40
Misses 54 54 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Martin Adámek <banan23@gmail.com>
It probably would make sense to create test suites for each language. Currently the QueryBuilder.test.ts file is only testing against MySQL from what I could see. |
There was a problem hiding this comment.
just two nits, please apply those suggestions to both drivers
otherwise ready to merge, thanks!
It probably would make sense to create test suites for each language. Currently the QueryBuilder.test.ts file is only testing against MySQL from what I could see.
part of that file is also about postgres, but agreed this would deserve a split and other drivers, probably not a complete copy of what we have there but at least for the differences
| @@ -74,4 +74,22 @@ export class MariaDbPlatform extends AbstractSqlPlatform { | |||
| return `alter table ${quotedTableName} add fulltext index ${quotedIndexName}(${quotedColumnNames.join(',')})`; | |||
| } | |||
|
|
|||
| private readonly NULLS_TRANSLATE = { | |||
There was a problem hiding this comment.
maybe lets remove those to ORDER_BY_NULLS_TRANSLATE?
There was a problem hiding this comment.
Sorry, did you mean rename (not remove)?
Co-authored-by: Martin Adámek <banan23@gmail.com>
kpervin
changed the title
B4nan
changed the title
order by nulls first/last
Fixes #5004
getOrderByExpressionto AbstractSqlPlatform.ts as an overridable method to formatorderByqueries. This uses syntax that is recognized by both SQLite and PostGreSQLgetOrderByExpressionto MariaDbPlatform.ts and MySqlPlatform.ts that adds functionality to handle(ASC|DESC) NULLS (FIRST|LAST)syntax