Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Synchronized TVs never triggered #202

Closed
arjen-t opened this issue Mar 18, 2024 · 0 comments
Closed

Bug: Synchronized TVs never triggered #202

arjen-t opened this issue Mar 18, 2024 · 0 comments

Comments

@arjen-t
Copy link
Contributor

arjen-t commented Mar 18, 2024

When defining synchronized TVs (comma-separated list of TV IDs), this never triggers the sync procedure.

The reason lies in the following line of code, line 290 in the Babel class.

/* synchronize the TVs of linked resources */
$syncTvs = $this->getOption('syncTvs');
if (empty($syncTvs) || !is_array($syncTvs)) {
/* there are no TVs to synchronize */
return;
}

The $syncTvs is retrieved from the setting on line 289. But the setting always returns a string, empty or comma-separated TV IDs. This causes the syncing never happens because it isnt an array.

Jako added a commit to Jako/Babel that referenced this issue Mar 18, 2024
Jako added a commit to Jako/Babel that referenced this issue Mar 18, 2024
Jako added a commit to Jako/Babel that referenced this issue Mar 18, 2024
Jako added a commit to Jako/Babel that referenced this issue Mar 27, 2024
- Add a menu entry/button to create multiple translations in selectable contexts
- Include a possible scrollbar height in the context grid height
- [mikrobi#204] New event when TV values have been synchronized
- Add an option to link a new created translation with all existing translations
- [mikrobi#202] Fix synchronized TVs never triggered
- Don't change the parent of a new linked resource to a folder
Jako added a commit to Jako/Babel that referenced this issue Mar 27, 2024
- Add a menu entry/button to create multiple translations in selectable contexts
- Include a possible scrollbar height in the context grid height
- [mikrobi#204] New event when TV values have been synchronized
- Add an option to link a new created translation with all existing translations
- [mikrobi#202] Fix synchronized TVs never triggered
- Don't change the parent of a new linked resource to a folder
Jako added a commit to Jako/Babel that referenced this issue Mar 27, 2024
- Add a menu entry/button to create multiple translations in selectable contexts
- Include a possible scrollbar height in the context grid height
- [mikrobi#204] New event when TV values have been synchronized
- Add an option to link a new created translation with all existing translations
- [mikrobi#202] Fix synchronized TVs never triggered
- Don't change the parent of a new linked resource to a folder
@Jako Jako mentioned this issue Mar 27, 2024
@Jako Jako closed this as completed Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants