Rewrite convert #381
Merged
Rewrite convert #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abergeron
approved these changes
Nov 9, 2020
|
Everything passes now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This rewrites the ConversionResource and infer_constant in the inferrer to be simpler. The tests seem to take 10-20% less time to execute overall with these changes. For example, for the RNN,
step_inferis about 30% faster because it doesn't reroute to new constants when the constants already contain converted value (also, it doesn't set a_convertedfield in nodes anymore, which had always been a dirty hack).I also fixed the debugger when using buche.