add Float32sr methods for DE.jl #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milankl
reviewed
Nov 16, 2022
milankl
reviewed
Dec 2, 2022
milankl
reviewed
Jan 12, 2023
|
Okay the error is unrelated but the same as in #61, will raise an issue about this separately. |
|
Hey @milankl is this PR now ok, with the exception of the CI test fail? |
|
Yes, looks good to me, but before we merge I want to address #62 so that main doesn't fail. Then I'm happy to put this into v0.6.1 |
milankl
approved these changes
Jun 29, 2023
|
Some remaining issues here might be because of compat with BFloat16s.jl = 0.1,0.2 prior to #69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Float32sr additions to enable integration with DE.jl