Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment counter #33

Merged
merged 6 commits into from
Aug 13, 2022
Merged

Add comment counter #33

merged 6 commits into from
Aug 13, 2022

Conversation

MxoDevops
Copy link
Collaborator

#5

Copy link
Owner

@milen-ale milen-ale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#33
@MxoDevops
❌ Invalid code request due to linter errors

Copy link
Owner

@milen-ale milen-ale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#33
@milen-ale approved this pull request

Status: Approved

@MxoDevops Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

cca0aa26-c843-47ac-bf97-7733936ba866_text

Highlights

  • Good use of git-flow ✔️

  • Linter result is green ✔️

  • node_modules folder is in the .gitignore ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise
Please, remember to tag me in your question so I can receive the notification.

  • [OPTIONAL] Commit messages must start with a Captial alphabet for best practice
  • Commit messages should be meaningful.
  • Pull request should have a descriptive title telling you what changes are inside.
  • Pull request should have a short summary describing introduced changes in more detail.

@MxoDevops MxoDevops merged commit 2c7f0a3 into dev Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants