Correct French translations for "Spoiler" and "Show" keys. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 'hide' => 'Cacher', | ||
| 'show' => 'Montrent', | ||
| 'show' => 'Montrer', |
There was a problem hiding this comment.
Using Afficher instead of Montrer looks better?
There was a problem hiding this comment.
Yes indeed. I had not though of it.
I should have push'd a new update in the pull request with your change.
Conflicts: src/config/messages.php
|
Google translate has failed me again! Haha, but on a serious note, thanks a lot for this! And the informative description. |
milesj
added a commit
that referenced
this pull request
Oct 31, 2014
Correct French translations for "Spoiler" and "Show" keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The translation for Spoiler and Show keys was incorrect :
There is no accurate one-word translation for Spoiler, the English word is used in place. The Latin word from which it comes from gave a word with different meaning ("spolier", which is linked to an old meaning of the word "spoiler", as a "looter", according to Wikipedia), which can't be used, and the proposed word "becquet" is a car spoiler.
The Show key was translated as "Montrent", instead of the infinitive form "Montrer". "Voir" can also be an acceptable input (lit. "See")
The key for mail is also an issue, in regard to the official language, as the word "courriel" should have been used, although I prefer the use of "mail" and/or "email", which is more popular in use, thus not needing correction.