Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: alpha beta experimental modifiers #53

Merged
merged 2 commits into from
Jul 18, 2022

Conversation

chadhietala
Copy link
Contributor

@chadhietala chadhietala commented Jul 15, 2022

This adds badges to entities that are marked with stabilitity modifiers. I'm open to
suggestions on better ways of rendering this information.

Screen Shot 2022-07-15 at 1 04 14 PM
Screen Shot 2022-07-15 at 1 03 39 PM

@chadhietala chadhietala changed the title feat: add support for @alpha, @beta, @experimental modifiers feat: alpha beta experimental modifiers Jul 15, 2022
This adds badges to entities that are marked with stabilitity modifiers. I'm open to
suggestions on better ways of rendering this information.
@chadhietala chadhietala changed the title feat: alpha beta experimental modifiers new: alpha beta experimental modifiers Jul 15, 2022
@milesj
Copy link
Owner

milesj commented Jul 15, 2022

@chadhietala I like the idea but I feel like the badges should be alongside the name. So "baz " or "Foo ". Can probably be done with a new CommentBadges or something component.

@chadhietala
Copy link
Contributor Author

chadhietala commented Jul 15, 2022

@milesj I think that makes sense. Locally I have members rendering like that but one of the things I'm not sure about is in reflections that can have multiple signatures (functions/methods). Technically each signature could have a different modifier on it. Do you think it would be ok to include the badges in body or do you think it would be better to have the heading change when clicking of different signatures?

The UI in question:
Screen Shot 2022-07-15 at 4 04 20 PM

Here's a preview of the members:
Screen Shot 2022-07-15 at 4 00 37 PM

@milesj
Copy link
Owner

milesj commented Jul 15, 2022

@chadhietala Properties look good, but yeah signatures is weird. I suppose putting them in the body is fine...

@chadhietala
Copy link
Contributor Author

Ok I think this is ready. Heres what I ended up with.
Screen Shot 2022-07-17 at 9 41 23 PM
Screen Shot 2022-07-17 at 9 41 16 PM
Screen Shot 2022-07-17 at 9 41 11 PM

@milesj
Copy link
Owner

milesj commented Jul 18, 2022

Awesome stuff!

@milesj milesj merged commit f32fa95 into milesj:master Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants