Make shapeless.the respect @implicitNotFound (Fix #671)

[Atry]

No description provided.

[codecov-io]

Current coverage is 81.56% (diff: 100%)

Merging #672 into master will not change coverage

@@             master       #672   diff @@
==========================================
  Files            69         69          
  Lines          2641       2641          
  Methods        2375       2375          
  Messages          0          0          
  Branches         92         92          
==========================================
  Hits           2154       2154          
  Misses          487        487          
  Partials          0          0          

Powered by Codecov. Last update fcc15a6...6768f0f

[milessabin]

Great stuff! I think that slient = false means that the following isEmpty condition will always be false ... could you check whether or not that's the case and if it is remove the conditional.

[Atry]

I removed the conditional and left an assert call instead

[milessabin]

Thanks! I think the assert should go though ... it's not validating any logic of ours, so doesn't really belong here.

[milessabin]

Sorry to keep chiselling away on this ... would you mind adding a test which verifies that the yields values with refined type members as described in the scaladoc?

[milessabin]

Bump ... I'll merge as soon as the additional test has been added.

[Atry]

Thank you.

[Atry]

Don't know how to test the error message

[milessabin]

Add a test of the form,

val foo = ...
foo: <type including refinement>

This will verify that the inferred type of foo is the expected type, including the expected refinement, without the refinement influencing type inference. Alternatively used assertTypedEquals.

[Atry]

This PR only changes the error message. How to test if the error message is expected?

[milessabin]

Whoops! Sorry, I'm confusing PRs :-)

You should be able to use illTyped with an expected error message here.

Please also squash the resulting commits.

[AndreasKostler]

I am not sure this does what it's expected to do (according to #671):

type Foo = the.`Ordering[Set[Int]]`.Ops
error: exception during macro expansion:
scala.reflect.macros.TypecheckException: implicit search has failed. to find out the reason, turn on -Xlog-implicits

expected

error:  No implicit Ordering defined for Set[Int]

[AndreasKostler]

I don't want to hijack this PR but I do have a working one if interested. See #742