Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IE8] Route.interpolate() doesn't work properly with rest segments and multiple optional segments #62

Closed
millermedeiros opened this issue Jun 21, 2012 · 0 comments
Closed

[IE8] Route.interpolate() doesn't work properly with rest segments and multiple optional segments #62

millermedeiros opened this issue Jun 21, 2012 · 0 comments
Labels
defect
Milestone
v0.9.1

Comments

@millermedeiros
Copy link
Owner

failing specs: https://github.com/millermedeiros/crossroads.js/blob/e1670d7b589ffadfe425c484288c05a602ff1d68/dev/tests/spec/interpolate.spec.js#L22-34
millermedeiros added a commit that referenced this issue Jul 29, 2012
@millermedeiros
Normalizes IE 7-8 RegExp behavior fixing many bugs.
7fe803e 
Optional capturing groups are matched as an empty string on IE 7-8
while it is matched as `undefined` on other browsers. The global
flag also causes some undesired side effects on IE 7-8 so make
sure we reset the `RegExp.lastIndex` during `captureVals`.

 - closes #gh-58
 - closes #gh-59
 - closes #gh-60
 - closes #gh-61
 - closes #gh-62
 - closes #gh-63
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
defect
Projects
None yet
Milestone
v0.9.1
Development

No branches or pull requests
1 participant
@millermedeiros