-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tf-next: Adds support for yarn workspaces #107
Conversation
Hmm, https://github.com/dealmore/terraform-aws-next-js/pull/107/checks?check_run_id=2279172762#step:6:810 seems like the failing tests seem related to them resolving to the correct directory but the base being different. |
Yeah the issue is that the sub-directory of the package ends up as prefix in the route config. 🙈 Will take another look soon. 😅 |
f2f71a0
to
95681a0
Compare
Nice one, thank you for all the effort. Tried it out locally and the lambda is now reporting a 403 - Missing authentication token. This error seemed to be an issue with This brings us one step closer, now we're at, we could be facing an issue where transpilation of
|
Yep, we currently only create |
Okay, sammy is fixed now and now also supports index routes. |
lol, now another test is failing (╯°□°)╯︵ ┻━┻ 😅 |
Now released in tf-next@0.7.0. |
Adds support for yarn workspaces to
tf-next build
command.ToDo
The thing is that we should should not change the original CWD (So entrypoint is always
/package.json
etc.), instead we should search for a yarn workspace root, and pass it as basedir when it exists.Fixes #93.