Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves routing for dynamic routes #17

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Improves routing for dynamic routes #17

merged 2 commits into from
Dec 21, 2020

Conversation

ofhouse
Copy link
Member

@ofhouse ofhouse commented Dec 7, 2020

This PR adds the following:

  • [Terraform] Destroy created S3 buckets on stack deletion
  • [Proxy] Better support for dynamic routes like /test/[id]/[something]
  • local e2e tests for test/fixtures/*

ToDo

  • Use Proxy as Lambda (With CloudFront events) in e2e tests
  • Use API-Gateway in AWS SAM for e2e tests
  • Original path is not passed into the lambda
    Possible Solution here would be to change the path in API Gateway to support proxy events:
    1. Change API Gateway path from /__NEXT_PAGE_LAMBDA_0 -> /__NEXT_PAGE_LAMBDA_0/{+proxy}
    2. Then we pass the original path from Cloudfront as proxy argument dealmore.de/abc/def/ghi -> __NEXT_PAGE_LAMBDA_0/abc/def/ghi
    3. We then remove the Lambda path /__NEXT_PAGE_LAMBDA_0 from the Path -> /abc/def/ghi
  • Make e2e test run with static file routes
  • Support for Fallback routes? -> Deferred Add support for fallbacks #19

--
Relates to #16.

@ofhouse ofhouse self-assigned this Dec 7, 2020
@ofhouse ofhouse mentioned this pull request Dec 8, 2020
@ofhouse ofhouse linked an issue Dec 19, 2020 that may be closed by this pull request
@ofhouse ofhouse removed a link to an issue Dec 19, 2020
Pull-Request: #17
Relates to issue #16
@ofhouse ofhouse marked this pull request as ready for review December 21, 2020 20:41
@ofhouse ofhouse merged commit 2163533 into main Dec 21, 2020
@ofhouse ofhouse deleted the issue/16 branch December 21, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant