Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change input selector to exclude the few that don't use common styling #271

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

khamer
Copy link

@khamer khamer commented Oct 10, 2020

Here's a PR For Issue #258 - as schirrel hasn't had a chance to get to it. I'm not sure if I think this is easier to read or more performant, but wanted to offer up the solution that @cjpatoilo was looking for.

@cjpatoilo cjpatoilo self-requested a review October 17, 2020 03:01
@cjpatoilo cjpatoilo self-assigned this Dec 22, 2020
@Sancxo
Copy link

Sancxo commented Oct 21, 2022

Hi guys,

I don't understand why this PR is not validated 2 years after ?

Actually it seems to fix a little issue I have : I made a form with, at the end, an input of type "file" with the submit button just after it; because the input[type="file"] is not present in the list of selectors in the forms style sheet, it doesn't have the "width: 100%" property as the others inputs, and because the button is specified as "inline-block" by Milligram I have my input "file" and the button on the same line. So I manually added the "width: 100%" for my input file in a CSS file to have them in two different lines, it's no big deal but the @khamer would naturally fix that.

@cjpatoilo: Is there still maintainers to the project to review and merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants