Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify SearchRequest for the SearchByPks use case (to be added) #178

Merged
merged 1 commit into from
Jul 7, 2023

Conversation

unfode
Copy link
Contributor

@unfode unfode commented Jun 29, 2023

This change is for MEP: Search By Primary Keys and milvus issue 23184: milvus-io/milvus#23184

@sre-ci-robot
Copy link

Welcome @unfode! It looks like this is your first PR to milvus-io/milvus-proto 🎉

@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jun 29, 2023
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. labels Jun 29, 2023
@yah01
Copy link
Member

yah01 commented Jun 30, 2023

/lgtm

@sre-ci-robot sre-ci-robot added lgtm and removed lgtm labels Jun 30, 2023
@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. ci-passed labels Jul 4, 2023
@mergify mergify bot added dco-passed DCO check passed. ci-passed and removed needs-dco DCO is missing in this pull request. labels Jul 4, 2023
Signed-off-by: unfode <forrest.futao.wei@gmail.com>
@congqixia
Copy link
Collaborator

/lgtm

@congqixia
Copy link
Collaborator

/approve

@sre-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, unfode

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 489c7ae into milvus-io:master Jul 7, 2023
3 checks passed
Writer-X added a commit to Writer-X/milvus-proto that referenced this pull request Jul 13, 2023
Update for the to-be-added SearchByPks RPC (milvus-io#178)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants