Skip to content

Commit

Permalink
enhance:[Cherry-Pick] change access log write cache default config (#…
Browse files Browse the repository at this point in the history
…34352)

pr: #34351

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
  • Loading branch information
aoiasd committed Jul 3, 2024
1 parent 8855008 commit 18668aa
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
3 changes: 2 additions & 1 deletion configs/milvus.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -226,7 +226,8 @@ proxy:
localPath: /tmp/milvus_access
filename: # Log filename, leave empty to use stdout.
maxSize: 64 # Max size for a single file, in MB.
cacheSize: 10240 # Size of log of memory cache, in B
cacheSize: 0 # Size of log write cache, in B
cacheFlushInterval: 3 # time interval of auto flush write cache, in Seconds. (Close auto flush if interval was 0)
rotatedTime: 0 # Max time for single access log file in seconds
remotePath: access_log/ # File path in minIO
remoteMaxTime: 0 # Max time for log file in minIO, in hours
Expand Down
8 changes: 4 additions & 4 deletions pkg/util/paramtable/component_param.go
Original file line number Diff line number Diff line change
Expand Up @@ -1305,17 +1305,17 @@ please adjust in embedded Milvus: false`,
p.AccessLog.CacheSize = ParamItem{
Key: "proxy.accessLog.cacheSize",
Version: "2.3.2",
DefaultValue: "10240",
Doc: "Size of log of memory cache, in B. (Close write cache if szie was 0",
DefaultValue: "0",
Doc: "Size of log of write cache, in B. (Close write cache if size was 0",
Export: true,
}
p.AccessLog.CacheSize.Init(base.mgr)

p.AccessLog.CacheFlushInterval = ParamItem{
Key: "proxy.accessLog.cacheSize",
Key: "proxy.accessLog.cacheFlushInterval",
Version: "2.4.0",
DefaultValue: "3",
Doc: "time interval of auto flush memory cache, in Seconds. (Close auto flush if interval was 0)",
Doc: "time interval of auto flush write cache, in Seconds. (Close auto flush if interval was 0)",
}
p.AccessLog.CacheFlushInterval.Init(base.mgr)

Expand Down

0 comments on commit 18668aa

Please sign in to comment.