Skip to content

Commit

Permalink
Add python functional tests about timeout (#2793)
Browse files Browse the repository at this point in the history
* Add python tests about param timeout

Signed-off-by: yangxuan <jumpthepig@gmail.com>

* add faiss configure args msg print

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

* change assertion conditions

Signed-off-by: yangxuan <xuan.yang@zilliz.com>

Co-authored-by: yangxuan <xuan.yang@zilliz.com>
  • Loading branch information
2 people authored and JinHai-CN committed Jul 18, 2020
1 parent b9380bc commit d001830
Show file tree
Hide file tree
Showing 2 changed files with 66 additions and 1 deletion.
2 changes: 2 additions & 0 deletions core/src/index/cmake/ThirdPartyPackagesCore.cmake
Expand Up @@ -545,6 +545,8 @@ macro(build_faiss)
--without-cuda)
endif ()

message(STATUS "Building FAISS with configure args -${FAISS_CONFIGURE_ARGS}")

if (DEFINED ENV{FAISS_SOURCE_URL})
set(FAISS_SOURCE_URL "$ENV{FAISS_SOURCE_URL}")
externalproject_add(faiss_ep
Expand Down
65 changes: 64 additions & 1 deletion tests/milvus_python_test/test_ping.py
Expand Up @@ -9,7 +9,7 @@ def test_server_version(self, connect):
'''
target: test get the server version
method: call the server_version method after connected
expected: version should be the pymilvus version
expected: version should be the milvus version
'''
status, res = connect.server_version()
assert res == __version__
Expand Down Expand Up @@ -54,6 +54,58 @@ def test_connected(self, connect):
assert connect


class TestPingWithTimeout:
def test_server_version_legal_timeout(self, connect):
'''
target: test get the server version with legal timeout
method: call the server_version method after connected with altering timeout
expected: version should be the milvus version
'''
status, res = connect.server_version(20)
assert res == __version__

def test_server_version_negative_timeout(self, connect):
'''
target: test get the server version with negative timeout
method: call the server_version method after connected with altering timeout
expected: when timeout is illegal raises an error;
'''
status, res = connect.server_version(-1)
assert not status.OK()

def test_server_cmd_with_params_version_with_legal_timeout(self, connect):
'''
target: test cmd: version and timeout
method: cmd = "version" , timeout=10
expected: when cmd = 'version', return version of server;
'''
cmd = "version"
status, msg = connect._cmd(cmd, 10)
logging.getLogger().info(status)
logging.getLogger().info(msg)
assert status.OK()
assert msg == __version__

def test_server_cmd_with_params_version_with_illegal_timeout(self, connect):
'''
target: test cmd: version and timeout
method: cmd = "version" , timeout=-1
expected: when timeout is illegal raises an error;
'''
status, res = connect.server_version(-1)
assert not status.OK()

def test_server_cmd_with_params_others_with_illegal_timeout(self, connect):
'''
target: test cmd: lalala, timeout = -1
method: cmd = "lalala", timeout = -1
expected: when timeout is illegal raises an error;
'''
cmd = "rm -rf test"
status, res = connect.server_version(-1)
assert not status.OK()


class TestPingDisconnect:
def test_server_version(self, dis_connect):
'''
Expand All @@ -76,3 +128,14 @@ def test_server_status(self, dis_connect):
with pytest.raises(Exception) as e:
status, msg = connect.server_status()
assert status is None

def test_server_version_with_timeout(self, dis_connect):
'''
target: test get the server status with timeout settings after disconnect
method: call the server_status method after connected
expected: status returned should be not ok
'''
status = None
with pytest.raises(Exception) as e:
status, msg = connect.server_status(100)
assert status is None

0 comments on commit d001830

Please sign in to comment.