Skip to content

Commit

Permalink
fix ut
Browse files Browse the repository at this point in the history
Signed-off-by: shaoting-huang <shaoting.huang@zilliz.com>
  • Loading branch information
shaoting-huang committed Jul 4, 2024
1 parent c288f64 commit d0bd06c
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 6 deletions.
2 changes: 1 addition & 1 deletion internal/storage/serde.go
Original file line number Diff line number Diff line change
Expand Up @@ -585,7 +585,7 @@ func (r *selectiveRecord) Schema() map[FieldID]schemapb.DataType {
}

func (r *selectiveRecord) ArrowSchema() *arrow.Schema {
return r.ArrowSchema()
return r.r.ArrowSchema()
}

func (r *selectiveRecord) Column(i FieldID) arrow.Array {
Expand Down
24 changes: 19 additions & 5 deletions internal/storage/serde_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,20 +102,34 @@ func TestSerDe(t *testing.T) {
}

func TestArrowSchema(t *testing.T) {
fields := []arrow.Field{{Name: "1", Type: arrow.BinaryTypes.String, Nullable: true}}
builder := array.NewBuilder(memory.DefaultAllocator, arrow.BinaryTypes.String)
builder.AppendValueFromString("1")
record := array.NewRecord(arrow.NewSchema(fields, nil), []arrow.Array{builder.NewArray()}, 1)
t.Run("test composite record", func(t *testing.T) {
fields := []arrow.Field{{Name: "1", Type: arrow.BinaryTypes.String, Nullable: true}}
builder := array.NewBuilder(memory.DefaultAllocator, arrow.BinaryTypes.String)
builder.AppendValueFromString("1")
arrays := []arrow.Array{builder.NewArray()}
cr := &compositeRecord{
recs: make(map[FieldID]arrow.Record, 1),
schema: make(map[FieldID]schemapb.DataType, 1),
}
cr.recs[0] = array.NewRecord(arrow.NewSchema(fields, nil), arrays, 1)
cr.recs[0] = record
cr.schema[0] = schemapb.DataType_String
expected := arrow.NewSchema(fields, nil)
assert.Equal(t, expected, cr.ArrowSchema())
})

t.Run("test simple arrow record", func(t *testing.T) {
cr := &simpleArrowRecord{
r: record,
schema: make(map[FieldID]schemapb.DataType, 1),
field2Col: make(map[FieldID]int, 1),
}
cr.schema[0] = schemapb.DataType_String
expected := arrow.NewSchema(fields, nil)
assert.Equal(t, expected, cr.ArrowSchema())

sr := newSelectiveRecord(cr, 0)
assert.Equal(t, expected, sr.ArrowSchema())
})
}

func BenchmarkDeserializeReader(b *testing.B) {
Expand Down

0 comments on commit d0bd06c

Please sign in to comment.