Skip to content

Commit

Permalink
enhance: Continue loop when reassign channel fails (#34331)
Browse files Browse the repository at this point in the history
Log will be confusing when `Reassign` channel operation failed for both
success & failure log will be printed in row. This PR continue the loop
to avoid this output.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
  • Loading branch information
congqixia committed Jul 4, 2024
1 parent c6e2900 commit d51d095
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions internal/datacoord/channel_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (
"time"

"github.com/cockroachdb/errors"
"github.com/golang/protobuf/proto"
"github.com/samber/lo"
"go.uber.org/zap"

Expand Down Expand Up @@ -488,6 +487,7 @@ func (m *ChannelManagerImplV2) advanceStandbys(_ context.Context, standbys []*No
zap.Int64("nodeID", nodeAssign.NodeID),
zap.Strings("channels", chNames),
)
continue
}

log.Info("Reassign standby channels to node",
Expand Down Expand Up @@ -523,7 +523,7 @@ func (m *ChannelManagerImplV2) advanceToNotifies(ctx context.Context, toNotifies
)
for _, ch := range nodeAssign.Channels {
innerCh := ch
tmpWatchInfo := proto.Clone(innerCh.GetWatchInfo()).(*datapb.ChannelWatchInfo)
tmpWatchInfo := typeutil.Clone(innerCh.GetWatchInfo())
tmpWatchInfo.Vchan = m.h.GetDataVChanPositions(innerCh, allPartitionID)

future := getOrCreateIOPool().Submit(func() (any, error) {
Expand Down

0 comments on commit d51d095

Please sign in to comment.