fix: reuse deserialize result to help improve memory management (#34507)

Fixed #33268 The original reuse is broken by #33359 Signed-off-by: Ted Xu <ted.xu@zilliz.com>
milvus-io · Jul 9, 2024 · eae4dfc · eae4dfc
1 parent eeb03a0
commit eae4dfc
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/internal/storage/serde.go b/internal/storage/serde.go
@@ -538,8 +538,9 @@ func (deser *DeserializeReader[T]) Next() error {
 		deser.pos = 0
 		deser.rec = deser.rr.Record()
 
-		// allocate new slice preventing overwrite previous batch
-		deser.values = make([]T, deser.rec.Len())
+		if deser.values == nil || len(deser.values) != deser.rec.Len() {
+			deser.values = make([]T, deser.rec.Len())
+		}
 		if err := deser.deserializer(deser.rec, deser.values); err != nil {
 			return err
 		}