Skip to content

Commit

Permalink
fix: can't generate traceID when use noop exporter (#33191)
Browse files Browse the repository at this point in the history
relate: #33190

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
  • Loading branch information
aoiasd committed May 21, 2024
1 parent 89ad3eb commit f8929cc
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions pkg/tracer/tracer.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import (
"go.opentelemetry.io/otel/sdk/resource"
sdk "go.opentelemetry.io/otel/sdk/trace"
semconv "go.opentelemetry.io/otel/semconv/v1.4.0"
"go.opentelemetry.io/otel/trace"
"go.uber.org/zap"

"github.com/milvus-io/milvus/pkg/log"
Expand Down Expand Up @@ -63,11 +62,6 @@ func CloseTracerProvider(ctx context.Context) error {
}

func SetTracerProvider(exp sdk.SpanExporter, traceIDRatio float64) {
if exp == nil {
otel.SetTracerProvider(trace.NewNoopTracerProvider())
return
}

tp := sdk.NewTracerProvider(
sdk.WithBatcher(exp),
sdk.WithResource(resource.NewWithAttributes(
Expand Down

0 comments on commit f8929cc

Please sign in to comment.