Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Add Tickle logic in channel reassign #21074

Closed
1 task done
xiaofan-luan opened this issue Dec 8, 2022 · 4 comments
Closed
1 task done

[Bug]: Add Tickle logic in channel reassign #21074

xiaofan-luan opened this issue Dec 8, 2022 · 4 comments
Assignees
Labels
kind/enhancement Issues or changes related to enhancement severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@xiaofan-luan
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Environment

- Milvus version:
- Deployment mode(standalone or cluster):
- SDK version(e.g. pymilvus v2.0.0rc2):
- OS(Ubuntu or CentOS): 
- CPU/Memory: 
- GPU: 
- Others:

Current Behavior

Current Data coord send a channel watch to datanode, and wait for Params.DataCoordCfg.MaxWatchDuration time before it decide to reassign the channel to another. datanode.

This may cause serious issues, especially when watch channel takes lager than Params.DataCoordCfg.MaxWatchDuration(happens on the case where there are many stats logs).

Expected Behavior

  1. Datanode keep modifying etcd path(Tickle), so datacoord won't timeout the assign, after tickle datacoord will only reset timeout and continue.

  2. Thinks of some way to improve stats log load. This becomes a serious issue when data channel becomes huge.

Steps To Reproduce

No response

Milvus Log

No response

Anything else?

No response

@xiaofan-luan xiaofan-luan added kind/enhancement Issues or changes related to enhancement needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 8, 2022
@xiaofan-luan xiaofan-luan added this to the 2.2.1 milestone Dec 8, 2022
@xiaofan-luan
Copy link
Contributor Author

/assign @aoiasd

@xiaofan-luan xiaofan-luan added triage/accepted Indicates an issue or PR is ready to be actively worked on. severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Dec 8, 2022
@yanliang567 yanliang567 modified the milestones: 2.2.1, 2.2.2, 2.2.3 Dec 19, 2022
@stale
Copy link

stale bot commented Jan 23, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Jan 23, 2023
@xiaofan-luan
Copy link
Contributor Author

keep it open

@stale stale bot removed the stale indicates no udpates for 30 days label Jan 24, 2023
@yanliang567 yanliang567 modified the milestones: 2.2.3, 2.2.4 Feb 14, 2023
@stale
Copy link

stale bot commented Mar 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Rotten issues close after 30d of inactivity. Reopen the issue with /reopen.

@stale stale bot added the stale indicates no udpates for 30 days label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Issues or changes related to enhancement severity/critical Critical, lead to crash, data missing, wrong result, function totally doesn't work. stale indicates no udpates for 30 days triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

3 participants