Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use tickle to check WatchEvent state at datacoord and datanode #21193

Merged
merged 1 commit into from Feb 15, 2023
Merged

Use tickle to check WatchEvent state at datacoord and datanode #21193

merged 1 commit into from Feb 15, 2023

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Dec 13, 2022

related:#21074
Signed-off-by: aoiasd zhicheng.yue@zilliz.com

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 13, 2022
@mergify mergify bot added the dco-passed DCO check passed. label Dec 13, 2022
@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2022

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 13, 2022

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 14, 2022

/run-cpu-e2e

@aoiasd
Copy link
Contributor Author

aoiasd commented Dec 14, 2022

rerun ut

@mergify
Copy link
Contributor

mergify bot commented Dec 14, 2022

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@aoiasd aoiasd force-pushed the AddTickle branch 2 times, most recently from 3de3e45 to cbc382c Compare December 14, 2022 10:34
@codecov
Copy link

codecov bot commented Dec 14, 2022 •
edited

Codecov Report

Merging #21193 (5b69f5f) into master (c2a49d5) will decrease coverage by 0.02%.
The diff coverage is 85.40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #21193      +/-   ##
==========================================
- Coverage   82.42%   82.41%   -0.02%     
==========================================
  Files         702      702              
  Lines       95677    95723      +46     
==========================================
+ Hits        78864    78886      +22     
- Misses      13840    13862      +22     
- Partials     2973     2975       +2
Impacted Files Coverage Δ
internal/datanode/data_node.go 73.65% <63.63%> (-2.72%) ⬇️
internal/datacoord/channel_manager.go 71.65% <73.33%> (+0.22%) ⬆️
internal/datanode/event_manager.go 81.39% <79.31%> (-18.61%) ⬇️
internal/datacoord/channel_checker.go 97.52% <100.00%> (+0.24%) ⬆️
internal/datacoord/policy.go 85.24% <100.00%> (ø)
internal/datanode/data_sync_service.go 81.08% <100.00%> (+0.32%) ⬆️
internal/datanode/flow_graph_manager.go 95.95% <100.00%> (ø)
internal/util/paramtable/component_param.go 98.04% <100.00%> (+0.02%) ⬆️
internal/querycoordv2/job/scheduler.go 88.42% <0.00%> (-6.32%) ⬇️
... and 20 more

@mergify
Copy link
Contributor

mergify bot commented Dec 15, 2022

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd aoiasd force-pushed the AddTickle branch 2 times, most recently from a5ffad6 to 6d59432 Compare February 9, 2023 12:05
@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Feb 9, 2023

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaofan-luan
Copy link
Contributor

/approve

@aoiasd
Copy link
Contributor Author

aoiasd commented Feb 10, 2023

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Feb 10, 2023
@aoiasd
Add tickle for datacoord watch event
5b69f5f 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@mergify mergify bot removed the ci-passed label Feb 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 13, 2023

@aoiasd ut workflow job failed, comment rerun ut can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Feb 14, 2023

rerun ut

@mergify mergify bot added the ci-passed label Feb 14, 2023
congqixia
congqixia reviewed Feb 15, 2023
View reviewed changes
internal/datanode/event_manager.go
if err != nil {
log.Error("fail to marshal watchInfo with progress at tickler",
zap.String("vChanName", t.watchInfo.Vchan.ChannelName),
zap.Int32("progree", nowProgress),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: typo

congqixia
congqixia approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 148a024 into milvus-io:master Feb 15, 2023
@congqixia congqixia added the behavior-change pr has behavior change label Feb 15, 2023
aoiasd added a commit to aoiasd/milvus that referenced this pull request Feb 16, 2023
@aoiasd
Add tickle for datacoord watch event (milvus-io#21193)
4fdb4fa 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Feb 17, 2023
@aoiasd
Add tickle for datacoord watch event (#21193) (#22209)
fbbbd6e 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees

@congqixia congqixia

Labels
approved behavior-change pr has behavior change ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aoiasd @congqixia @xiaofan-luan @sre-ci-robot