Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]: plan parser take too much cpu on high concurrency cases #32868

Closed
1 task done
xiaofan-luan opened this issue May 8, 2024 · 1 comment · Fixed by #32869
Closed
1 task done

[Enhancement]: plan parser take too much cpu on high concurrency cases #32868

xiaofan-luan opened this issue May 8, 2024 · 1 comment · Fixed by #32869
Assignees
@xiaofan-luan
Labels
kind/enhancement Issues or changes related to enhancement

Comments

@xiaofan-luan
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

What would you like to be added?

image

under high QPS(more than 10000), we see significant cpu usage on lexer and parser creation, which could be avoid by pool service

Why is this needed?

No response

Anything else?

No response
@xiaofan-luan xiaofan-luan added the kind/enhancement Issues or changes related to enhancement label May 8, 2024
@xiaofan-luan xiaofan-luan self-assigned this May 8, 2024
@xiaofan-luan xiaofan-luan mentioned this issue May 8, 2024
Merged
@xiaofan-luan
Copy link
Contributor Author

@zhagnlu parser becomes the major bottleneck on the not in use case

sre-ci-robot pushed a commit that referenced this issue May 11, 2024
@xiaofan-luan
enhance: optimize plan parser pool to avoid unnessary recycle (#32869)
36f1ea9 
fix #32868
plan parser takes too much cpu on high qps,this pr try to avoid create
lexer and parser too freequent

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xiaofan-luan xiaofan-luan

Labels
kind/enhancement Issues or changes related to enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enhance: optimize plan parser pool to avoid unnessary recycle xiaofan-luan/milvus
1 participant
@xiaofan-luan